Improvement and feature addition and Update from deprecated libraries to new ones#8
Open
FlixCoder wants to merge 23 commits intojackm321:masterfrom
Open
Improvement and feature addition and Update from deprecated libraries to new ones#8FlixCoder wants to merge 23 commits intojackm321:masterfrom
FlixCoder wants to merge 23 commits intojackm321:masterfrom
Conversation
added 21 commits
October 4, 2017 17:37
…ad of external crates, bugfixes added L2 reularization replaced sigmoid by ReLU activation
Author
|
Oh sorry, I forgot to add the .trayis.yml. It is in now. |
Author
|
This fork adds L2 regularization and several activation functions to the original crate. Additionally, there are a few minor improvements. Lambda can be set just like the learning rate. The activation functions for hidden and output gets set in NN::new as second and third parameter respectively. |
|
@jackm321 I'd like to see this PR merged. I tried using the nn crate in a WebAssembly project but it failed to build because nn relies on the outdated rustc-serialize package which doesn't compile for WebAssembly (See wasm-bindgen/wasm-bindgen#1488). This change would fix that problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At first, I did not plan to create a pull request and to keep everything clean and abstract. But I think the improvements got really useful, so I decided to clean up and update the doc and README accordingly, but I don't know, if everything is still good enough. If there is something minor not ok, please tell me, so I can fix and you can merge safely.